Glasgow | ITP-JAN-2026 | Tuan Nguyen | Sprint 1 | Wireframe#1033
Glasgow | ITP-JAN-2026 | Tuan Nguyen | Sprint 1 | Wireframe#1033Jacknguyen4438 wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
…tween the link and paragraph
…ke for the course work.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello I just add this image of my website lighthouse test. I hope this for further proof of my light house test, if this shouldn't be the right way to do it please let me know. |
Jacknguyen4438
added
the
Needs Review
Jacknguyen4438
changed the title
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Jacknguyen4438
changed the title
Jacknguyen4438
added
Needs Review
Create a different branch from the same repo for Form-Controls exercise. (Note: If we already have forked a repo to our account, we cannot create another fork from the same repo to our account). |
cjyuan
added
Review in progress
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is free or syntax error. Well done.
- When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you
- Center the "SHORT DESCRIPTION" (the text beneath the title)
- Align the height of the images in articles 2 and 3.
- Align the right border of articles 1 and 3.
- The articles are not quite centered on the page (there are more space on the right of the articles)
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).
-
Could consider leaving more space between the text and the article's border. Currently the text almost touches the border.
| <img src="https://media.licdn.com/dms/image/v2/D4D12AQH6ykM-AVoDKg/article-cover_image-shrink_720_1280/B4DZZW5EzAHAAM-/0/1745214525491?e=2147483647&v=beta&t=kB_Gy_FceQSnp1FMZ2lVvoPis3lrcCQjgX0Zur3z4pc" alt="a detail map on what is git and branch" class="image-size-2" /> | ||
| <h2>Git, repo and branch</h2> | ||
| <p > | ||
| Git, repo and branch are some basic knowledge that you should learn when you start programming. They can be a powerful tool |
There was a problem hiding this comment.
Indentation is a bit off. Could consider using a code formatter to auto format the code.
VSCode's "Format Document" feature can help us format our code for better readability and consistency.
To use the feature, right-click inside the code editor and select the option.
| body{ | ||
| background-image: linear-gradient(to right top, #051937, #004d7a, #008793, #00bf72, #a8eb12); | ||
| } |
There was a problem hiding this comment.
Can also use a code-formatter to help you indent the CSS code.
cjyuan
added
Reviewed
|
Hello @cjyuan thank you for review my pull request. I read your review and see some fix and improvement need to be done, I will do it as soon as possible for ready again to be review. |
2 participants
Self checklist
Changelist
Hello, I have finish this course work and would like to have a review if possible. Inside the wireframe fold I have modify HTML, CSS
and README.md file for the course.
Questions
Yes I would like to ask a question. Do I have to used this repo for my sprint 2 course work? if so can I do the sprint 2 course in this same repo or I have to clone it again for sprint 2 course work?